Fix line display from home to first waypoint if no takeoff point#708
Merged
1Blademaster merged 2 commits intorelease-alpha-0.1.10from Sep 23, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fix the path rendering from home to the first waypoint when no explicit takeoff command exists, moving this responsibility from HomeMarker into missionItems.
- Move home-to-first-waypoint line logic into missionItems and derive it based on presence/position of a takeoff command.
- Replace state/effects with memoization for computing coordinates; adjust line styles and widths.
- Remove HomeMarker lineTo prop and related drawing.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| gcs/src/components/missions/missionsMap.jsx | Remove HomeMarker lineTo prop usage. |
| gcs/src/components/mapComponents/missionItems.jsx | Compute solid/dotted lines relative to home and takeoff; refactor to useMemo; update line styles. |
| gcs/src/components/mapComponents/homeMarker.jsx | Remove DrawLineCoordinates usage and lineTo prop from HomeMarker. |
| gcs/src/components/dashboard/map.jsx | Remove HomeMarker lineTo prop usage. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
NexInfinite
approved these changes
Sep 23, 2025
1Blademaster
deleted the
alpha-0.1.10/707-show-dashed-line-from-home-to-first-waypoint-if-no-takeoff
branch
1Blademaster
added a commit
that referenced
this pull request
Sep 28, 2025
* Fix line display from home to first waypoint if no takeoff point * Address copilot review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.